Conversation
LukaszRozmej
approved these changes
Jun 3, 2024
1978137 to
ecfd954
Compare
flcl42
reviewed
Jun 3, 2024
smartprogrammer93
approved these changes
Jun 3, 2024
|
Was Nethermind returning a commit hash with length < 8 prior to this change? We are getting errors connecting LH to Nethermind v1.26:
|
Contributor
|
@michaelsproul it used to return longer than 8: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Microsoft.Build.Tasks.Gitpackage to incorporate the commit hash into the version string.gitdirectory to Docker containers, which significantly increases local Docker image build timesClientVersionV1testsTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update